codeconsole commented on PR #2949: URL: https://github.com/apache/groovy/pull/2949#issuecomment-6506921438
Thanks, Daniel. On treating the breaks as first-class migration items (points 3 and 5): - **`COMPATIBILITY.md`** (b6d43bc) now has a "Groovy 7 — groovy-yaml, groovy-toml and groovy-csv use Jackson 3 (GROOVY-12433)" section beside the other Groovy 7 entries. It lists each change with who is affected and what to do: YAML scalar resolution, Jackson 2 databind annotations, typed XML following the classpath, Jackson 2 and SnakeYAML no longer transitive, and parser limits. It also says what stays the same. - **The PR description's breaking changes** point to that section and now include the parser limits as well. The YAML, TOML, CSV and XML guides keep their notes beside typed parsing, and `YamlScalarResolutionTest` pins the scalar behaviour. On the limits (point 4), I measured both versions to get the wording right. YAML and TOML input deeper than 500 levels now fails, where Jackson 2 allowed 1000. The string-length increase only matters for TOML: neither version length-checks CSV fields, and both cap a YAML document at 3,145,728 code points. The PR description says so now. On the scalar change, thanks for weighing in on the [dev@ thread](https://lists.apache.org/thread.html/t5nf7xk17wvf1dbol40ock8thg771rz3). Jochen's point that this isn't YAML 1.2 core either is in the wording: the guide and `COMPATIBILITY.md` both say the resolver is the JSON schema, stricter than the core schema, and name the values that change. I've also merged master again. It merged cleanly, and the yaml, toml, csv, xml (including `jackson2Test`) and json tests pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
