NSAmelchev commented on a change in pull request #8145:
URL: https://github.com/apache/ignite/pull/8145#discussion_r471478243
##########
File path:
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySpi.java
##########
@@ -2115,6 +2109,23 @@ protected void onExchange(DiscoveryDataPacket
dataPacket, ClassLoader clsLdr) {
@Override public void spiStart(@Nullable String igniteInstanceName) throws
IgniteSpiException {
initializeImpl();
+ MetricRegistry discoReg =
Review comment:
Can be one-line
##########
File path:
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySpi.java
##########
@@ -359,7 +364,7 @@
private Marshaller marsh;
/** Statistics. */
- protected final TcpDiscoveryStatistics stats = new
TcpDiscoveryStatistics();
+ protected TcpDiscoveryStatistics stats;
Review comment:
Now we can get NPE from public methods until SPI was started.
##########
File path:
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySpi.java
##########
@@ -1358,15 +1363,6 @@ public long getPendingMessagesRegistered() {
return stats.pendingMessagesRegistered();
}
- /**
- * Gets pending messages discarded count.
- *
- * @return Pending messages registered count.
- */
- public long getPendingMessagesDiscarded() {
Review comment:
Why the public API was changed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
