NSAmelchev commented on a change in pull request #8145:
URL: https://github.com/apache/ignite/pull/8145#discussion_r471489407
##########
File path:
modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySpiMBeanTest.java
##########
@@ -64,21 +70,121 @@
*/
@Test
public void testMBean() throws Exception {
- startGrids(3);
+ int cnt = 3;
+ int cliIdx = cnt - 1;
+
+ startGrids(cnt - 1);
+ startClientGrid(cliIdx);
+
+ ClusterNode crd =
U.oldest(grid(0).context().discovery().aliveServerNodes(), null);
+
+ assertNotNull(crd);
try {
- for (int i = 0; i < 3; i++) {
+ for (int i = 0; i < cnt; i++) {
IgniteEx grid = grid(i);
+ MetricRegistry discoReg =
grid.context().metric().registry(DISCO_METRICS);
+
TcpDiscoverySpiMBean bean =
getMxBean(grid.context().igniteInstanceName(), "SPIs",
TcpDiscoverySpi.class, TcpDiscoverySpiMBean.class);
assertNotNull(bean);
+
assertEquals(grid.cluster().topologyVersion(),
bean.getCurrentTopologyVersion());
+ assertEquals(grid.cluster().topologyVersion(),
+
discoReg.<LongMetric>findMetric("CurrentTopologyVersion").value());
+
+ if (i != cliIdx) {
+ assertEquals(crd.id(), bean.getCoordinator());
+ assertEquals(crd.id(),
discoReg.<ObjectMetric<UUID>>findMetric("Coordinator").value());
+ }
+ else {
+ assertNull(bean.getCoordinator());
+ assertNull(discoReg.findMetric("Coordinator"));
+ }
+
+ if (grid.localNode().id().equals(bean.getCoordinator())) {
+ assertTrue(bean.getCoordinatorSinceTimestamp() > 0);
+
assertTrue(discoReg.<LongMetric>findMetric("CoordinatorSince").value() > 0);
+ }
+ else {
+ assertEquals(0, bean.getCoordinatorSinceTimestamp());
+
+ if (i == cliIdx)
+ assertNull(discoReg.findMetric("CoordinatorSince"));
+ else
+ assertEquals(0L,
discoReg.<LongMetric>findMetric("CoordinatorSince").value());
+ }
+
+ // `getNodesJoined` returns count of joined nodes since local
node startup.
+ assertEquals((cnt - 1) - i, bean.getNodesJoined());
+ assertEquals((cnt - 1) - i,
discoReg.<IntMetric>findMetric("JoinedNodes").value());
+
+ assertEquals(0L, bean.getNodesFailed());
+ assertEquals(0,
discoReg.<IntMetric>findMetric("FailedNodes").value());
+
+ assertEquals(0L, bean.getNodesLeft());
+ assertEquals(0,
discoReg.<IntMetric>findMetric("LeftNodes").value());
+
+ assertTrue(bean.getTotalReceivedMessages() > 0);
+
assertTrue(discoReg.<IntMetric>findMetric("TotalReceivedMessages").value() > 0);
+
+ assertTrue(bean.getTotalProcessedMessages() > 0);
+
assertTrue(discoReg.<IntMetric>findMetric("TotalProcessedMessages").value() >
0);
+
+ if (i != cliIdx) {
+ assertTrue(bean.getPendingMessagesRegistered() > 0);
+
assertTrue(discoReg.<IntMetric>findMetric("PendingMessagesRegistered").value()
> 0);
+ }
+ else {
+ assertEquals(0, bean.getPendingMessagesRegistered());
+ assertEquals(0,
discoReg.<IntMetric>findMetric("PendingMessagesRegistered").value());
+ }
+
+ assertEquals(0, bean.getPendingMessagesDiscarded());
bean.dumpRingStructure();
assertTrue(strLog.toString().contains("TcpDiscoveryNodesRing"));
+
+ assertFalse(bean.getProcessedMessages().isEmpty());
+ assertFalse(bean.getReceivedMessages().isEmpty());
+ assertTrue(bean.getMaxMessageProcessingTime() > 0);
+ assertEquals(i == cliIdx, bean.isClientMode());
+ }
+
+ stopGrid(0);
+
+ crd = U.oldest(grid(1).context().discovery().aliveServerNodes(),
null);
+
+ for (int i = 1; i < cnt; i++) {
+ IgniteEx grid = grid(i);
+
+ MetricRegistry discoReg =
grid.context().metric().registry(DISCO_METRICS);
+
+ TcpDiscoverySpiMBean bean =
getMxBean(grid.context().igniteInstanceName(), "SPIs",
+ TcpDiscoverySpi.class, TcpDiscoverySpiMBean.class);
+
+ assertNotNull(bean);
+
+ assertEquals(grid.cluster().topologyVersion(),
bean.getCurrentTopologyVersion());
+ assertEquals(grid.cluster().topologyVersion(),
+
discoReg.<LongMetric>findMetric("CurrentTopologyVersion").value());
+
+ if (i != cliIdx) {
+ assertEquals(crd.id(), bean.getCoordinator());
+ assertEquals(crd.id(),
discoReg.<ObjectMetric<UUID>>findMetric("Coordinator").value());
+ }
+
+ if (grid.localNode().id().equals(crd.id())) {
+ assertTrue(bean.getCoordinatorSinceTimestamp() > 0);
+
assertTrue(discoReg.<LongMetric>findMetric("CoordinatorSince").value() > 0);
+ }
+
+ assertEquals(1L, bean.getNodesLeft());
+ assertEquals(1,
discoReg.<IntMetric>findMetric("LeftNodes").value());
}
+
Review comment:
Why this changed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
