alex-plekhanov commented on a change in pull request #33: URL: https://github.com/apache/ignite-extensions/pull/33#discussion_r570808096
########## File path: modules/spring-data-commons/src/main/java/org/apache/ignite/internal/transactions/proxy/ClientTransactionProxy.java ########## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.transactions.proxy; + +import org.apache.ignite.client.ClientTransaction; +import org.apache.ignite.internal.util.typedef.internal.S; + +/** + * Represents {@link TransactionProxy} implementation that uses {@link ClientTransaction} to perform transaction + * operations. + */ +public class ClientTransactionProxy implements TransactionProxy { Review comment: As far as I understand transaction proxies don't use anyhow cache data proxies and cache data proxies don't use anyhow transactions proxies. Transactions proxies required only by one module spring-tx, this module can be used without spring data, so I think we should move back these classes to spring-tx module. Moreover, there is no dependency from spring-tx to spring-data-commons module. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
