ivandasch commented on a change in pull request #8686: URL: https://github.com/apache/ignite/pull/8686#discussion_r577514522
########## File path: modules/ducktests/tests/checks/utils/check_controls_util_parameters.py ########## @@ -0,0 +1,248 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +""" +Checks Control Utility params pasrsing +""" + +import pytest +from ignitetest.services.utils.auth.creds_provider import CredsProvider, DEFAULT_AUTH_LOGIN, DEFAULT_AUTH_PASSWORD +from ignitetest.services.utils.ssl.ssl_factory import SslContextFactory, DEFAULT_PASSWORD, DEFAULT_TRUSTSTORE, \ + DEFAULT_ADMIN_KEYSTORE +from ignitetest.services.utils.control_utility import ControlUtility + + +class Cluster: + """ + Need this to initialise ControlUtility + """ + + def __init__(self, globals_dict): + self.context = Context(globals_dict) + self.certificate_dir = '/opt/certs/' + + +class Context: + """ + Need this to initialise ControlUtility + """ + + def __init__(self, globals_dict): + self.logger = '' + self.globals = globals_dict + + +def compare_ssl(class1, class2): + """ + Compare two SslContextFactory objects + """ + + if class1 is None and class2 is None: + return True + if isinstance(class1, SslContextFactory) and isinstance(class2, SslContextFactory): + return class1.__dict__ == class2.__dict__ + return False + + +def compare_creds(class1, class2): + """ + Compare two CredsProvider objects + """ + + if class1 is None and class2 is None: + return True + if isinstance(class1, CredsProvider) and isinstance(class2, CredsProvider): + return class1.__dict__ == class2.__dict__ + return False + + +class TestParams: + """ + Globals and Kwargs for tests + """ + + test_ssl_jks = {'key_store_jks': 'admin1.jks', 'key_store_password': 'qwe123', + 'trust_store_jks': 'truststore.jks', 'trust_store_password': 'qwe123'} + test_ssl_path = {'key_store_path': '/opt/certs/admin1.jks', 'key_store_password': 'qwe123', + 'trust_store_path': '/opt/certs/truststore.jks', + 'trust_store_password': 'qwe123'} + test_ssl_only_key = {'key_store_jks': 'admin1.jks'} + + test_creds = {'login': 'admin1', 'password': 'qwe123'} + test_creds_only_login = {'login': 'admin1'} + + expected_ssl = SslContextFactory(key_store_path='/opt/certs/admin1.jks', + key_store_password='qwe123', + trust_store_path='/opt/certs/truststore.jks', + trust_store_password='qwe123') + expected_ssl_default = SslContextFactory(key_store_path='/opt/certs/'+DEFAULT_ADMIN_KEYSTORE, + key_store_password=DEFAULT_PASSWORD, + trust_store_path='/opt/certs/'+DEFAULT_TRUSTSTORE, + trust_store_password=DEFAULT_PASSWORD) + expected_ssl_only_key = SslContextFactory(key_store_path='/opt/certs/admin1.jks', + key_store_password=DEFAULT_PASSWORD, + trust_store_path='/opt/certs/'+DEFAULT_TRUSTSTORE, + trust_store_password=DEFAULT_PASSWORD) + + expected_creds = CredsProvider(login='admin1', + password='qwe123') + expected_creds_default = CredsProvider(login=DEFAULT_AUTH_LOGIN, + password=DEFAULT_AUTH_PASSWORD) + expected_creds_only_login = CredsProvider(login='admin1', + password=DEFAULT_AUTH_PASSWORD) + + +class CheckCaseGlobalsSetKwargsNotSetSsl: + """ + Check that control_utulity.py correctly parse SSL params from globals + """ + + @staticmethod + @pytest.mark.parametrize('test_globals, test_kwargs, expected', + [({'use_ssl': True, + 'admin': {'ssl': TestParams.test_ssl_jks}}, {}, TestParams.expected_ssl), + ({'use_ssl': True, + 'admin': {'ssl': TestParams.test_ssl_path}}, {}, TestParams.expected_ssl), + ({'use_ssl': True, + 'admin': {'ssl': TestParams.test_ssl_only_key}}, {}, TestParams.expected_ssl_only_key), + ({'admin': {'ssl': TestParams.test_ssl_jks}}, {}, None), ]) + def check_parse(test_globals, test_kwargs, expected): + """ + Check that control_utulity.py correctly parse SSL params from globals + """ + + assert compare_ssl(ControlUtility(Cluster(test_globals), **test_kwargs).ssl_context, expected) + + +class CheckCaseGlobalsNotSetKwargsSetSsl: + """ + Check that control_utulity.py correctly parse SSL params from kwargs + """ Review comment: Some problem with identation ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
