alex-plekhanov commented on a change in pull request #9103:
URL: https://github.com/apache/ignite/pull/9103#discussion_r643100417
##########
File path:
modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/FunctionsTest.java
##########
@@ -86,7 +86,9 @@ public void testRange() {
"Increment can't be 0");
}
- /** */
+ /** Important! Don`t change query call sequence in this test. This also
tests correctness of
+ * {@link
org.apache.ignite.internal.processors.query.calcite.exec.exp.ExpressionFactoryImpl#SCALAR_CACHE}
usage.
Review comment:
I mean we should explicitly check some conditions here if we really test
the correctness of cache. For example, I've changed the queries call sequence
and nothing happens, the test still green, but javadoc states that after such a
change something bad should happen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
