korlov42 commented on a change in pull request #9476:
URL: https://github.com/apache/ignite/pull/9476#discussion_r735608726
##########
File path:
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/schema/SchemaHolder.java
##########
@@ -27,5 +27,5 @@
/**
* @return Schema.
*/
- SchemaPlus schema();
+ SchemaPlus schema(String schema);
Review comment:
let's mark the `schema` param as `@Nullable`. Also javadoc should be
updated as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
