korlov42 commented on a change in pull request #9476:
URL: https://github.com/apache/ignite/pull/9476#discussion_r735616491



##########
File path: 
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/ExecutionService.java
##########
@@ -19,31 +19,22 @@
 
 import java.util.List;
 import java.util.UUID;
-
 import org.apache.ignite.cache.query.FieldsQueryCursor;
-import org.apache.ignite.internal.processors.query.QueryContext;
+import org.apache.ignite.internal.processors.query.calcite.RootQuery;
+import org.apache.ignite.internal.processors.query.calcite.prepare.QueryPlan;
 import org.apache.ignite.internal.processors.query.calcite.util.Service;
-import org.jetbrains.annotations.Nullable;
 
 /**
  *
  */
-public interface ExecutionService extends Service {
-    /**
-     * Executes a query.
-     *
-     * @param ctx Query external context, contains flags and connection 
settings like a locale or a timezone.
-     * @param schema Schema name.
-     * @param query Query.
-     * @param params Query parameters.
-     * @return Query cursor.
-     */
-    List<FieldsQueryCursor<List<?>>> executeQuery(@Nullable QueryContext ctx, 
String schema, String query, Object[] params);
-
+public interface ExecutionService<Row> extends Service {
     /**
      * Cancels a running query.
      *
      * @param queryId Query ID.
      */
     void cancelQuery(UUID queryId);
-}
+
+    /** */
+    FieldsQueryCursor<List<?>> executePlan(RootQuery<Row> qry, QueryPlan plan);
+}

Review comment:
       new line is required at the end




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to