Vladsz83 commented on a change in pull request #9665:
URL: https://github.com/apache/ignite/pull/9665#discussion_r771861075



##########
File path: 
modules/core/src/main/java/org/apache/ignite/internal/binary/BinarySerializedFieldComparator.java
##########
@@ -247,55 +246,16 @@ public static boolean 
equals(BinarySerializedFieldComparator c1, BinarySerialize
                 Object val1 = c1.currentField();
                 Object val2 = c2.currentField();
 
-                return isArray(val1) ? compareArrays(val1, val2) : F.eq(val1, 
val2);
+                return isArray(val1) ? F.arrayEq(val1, val2) : F.eq(val1, 
val2);

Review comment:
       Should we remane `BinarySerializedFieldComparator#isArray()` to 
something like `isArrayOrBinaryArray()` or fix its description? It looks a bit 
wierd compared to F.isArray().




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to