nizhikov commented on a change in pull request #9665:
URL: https://github.com/apache/ignite/pull/9665#discussion_r771922157
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryArray.java
##########
@@ -251,6 +253,17 @@ public String componentClassName() {
&& Arrays.deepEquals(this.arr, arr.arr);
}
+ /** {@inheritDoc} */
+ @Override public int compareTo(@NotNull BinaryArray o) {
+ if (componentTypeId() != o.componentTypeId()) {
Review comment:
> Can componentTypeId() return changing value from
ctx.typeId(compClsName) after component registration?
No.
Mapping `compClsName -> typeId` should be idempotent and equal on all nodes,
by contract.
> Can we meet different comparisons on the same binary arrays?
Logic with "use typeId or typeId(compClsName)" implemented to overcome this
case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
