rpuch commented on code in PR #847:
URL: https://github.com/apache/ignite-3/pull/847#discussion_r888840040
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/mv/Timestamps.java:
##########
@@ -64,6 +65,19 @@ public static int writeTimestamp(long addr, int offset,
@Nullable Timestamp time
return 2 * Long.BYTES;
}
+ /**
+ * Writes a {@link Timestamp} to a buffer.
+ *
+ * @param buffer buffer to which to write
+ * @param timestamp the timestamp to write
+ */
+ public static void writeTimestampToBuffer(ByteBuffer buffer, @Nullable
Timestamp timestamp) {
Review Comment:
Because `Timestamp` should not probably know anything about page memory and
its specifics
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]