rpuch commented on code in PR #847:
URL: https://github.com/apache/ignite-3/pull/847#discussion_r888845110
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/mv/io/RowVersionDataIo.java:
##########
@@ -60,25 +60,54 @@ protected void writeRowData(long pageAddr, int dataOff, int
payloadSize, RowVers
putShort(addr, 0, (short) payloadSize);
addr += 2;
- addr += Timestamps.writeTimestamp(addr, 0, row.timestamp());
+ addr += Timestamps.writeTimestampToMemory(addr, 0, row.timestamp());
addr += PartitionlessLinks.writeToMemory(addr, row.nextLink());
- ByteBuffer value = row.value();
- putInt(addr, 0, value.limit());
+ putInt(addr, 0, row.valueSize());
addr += 4;
- putByteBuffer(addr, 0, value);
+ putByteBuffer(addr, 0, row.value());
}
/** {@inheritDoc} */
@Override
protected void writeFragmentData(RowVersion row, ByteBuffer buf, int
rowOff, int payloadSize) {
assertPageType(buf);
- // TODO: IGNITE-17009 - implement
+ if (rowOff == 0) {
+ // first fragment
+ assert row.headerSize() <= payloadSize : "Header must entirely fit
first fragment, but header size is " + row.headerSize()
Review Comment:
Thanks, applied your suggestion manually
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
