Mmuzaf commented on code in PR #10157:
URL: https://github.com/apache/ignite/pull/10157#discussion_r942742884
##########
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/GridCacheConfigurationConsistencySelfTest.java:
##########
@@ -140,7 +138,7 @@ public void testCacheUtilsCheckAttributeMismatch() throws
Exception {
final GridStringLogger strLog = new GridStringLogger(false, log);
- CU.checkAttributeMismatch(strLog, "cache", node.id(), "cacheMode",
"Cache mode", LOCAL, PARTITIONED, false);
+ CU.checkAttributeMismatch(strLog, "cache", node.id(), "cacheMode",
"Cache mode", REPLICATED, PARTITIONED, false);
Review Comment:
The `testCacheUtilsCheckAttributeMismatch` test validates only the
`checkAttributeMismatch` method and nothing more. So, in this change we may set
any value that differs from the `PARTITIONED` and it seems it will be correct
for tests.
Anyway the test can be removed, however, I think in this PR we should keep
it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
