timoninmaxim commented on code in PR #10292:
URL: https://github.com/apache/ignite/pull/10292#discussion_r1005692600
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/FileWriteAheadLogManager.java:
##########
@@ -2475,12 +2469,45 @@ private void deleteObsoleteRawSegments() {
if (segmentReservedOrLocked(desc.idx))
return;
- if (desc.idx < lastCheckpointPtr.index() &&
duplicateIndices.contains(desc.idx))
- segmentAware.addSize(desc.idx,
-deleteArchiveFiles(desc.file));
+ if (desc.idx < lastCheckpointPtr.index() &&
duplicateIndices.contains(desc.idx)) {
+ long sz = deleteArchiveFiles(desc.file);
+
+ segmentAware.addSize(desc.idx, -sz);
+ }
}
}
}
+ /** {@inheritDoc} */
+ @Override public File compressedSegment(long idx) {
+ return archiveSegment(idx, ZIP_SUFFIX);
Review Comment:
Also `archiveSegment` must return `null` if archive is disabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
