rpuch commented on code in PR #1407:
URL: https://github.com/apache/ignite-3/pull/1407#discussion_r1045451239
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/tree/BplusTree.java:
##########
@@ -1573,17 +1573,18 @@ public final T findOne(L row) throws
IgniteInternalCheckedException {
}
/**
- * Searches for the next row from the passed from the arguments.
+ * Searches for the lowerBound that (strictly or loosely, depending on
{@code includeRow}) follows the lowerBound passed as an
+ * argument.
*
- * @param row Row.
- * @param includeRow {@code True} if you include the passed row in the
result.
- * @return Next row.
+ * @param lowerBound Lower bound..
+ * @param includeRow {@code True} if you include the passed lowerBound in
the result.
+ * @return Next lowerBound.
Review Comment:
```suggestion
* @param includeRow {@code True} if you include the passed row in the
result.
* @return Next row.
```
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/tree/BplusTree.java:
##########
@@ -1592,9 +1593,9 @@ public final T findOne(L row) throws
IgniteInternalCheckedException {
} catch (CorruptedDataStructureException e) {
throw e;
} catch (IgniteInternalCheckedException e) {
- throw new IgniteInternalCheckedException("Runtime failure on
lookup next row: " + row, e);
+ throw new IgniteInternalCheckedException("Runtime failure on
lookup next lowerBound: " + lowerBound, e);
Review Comment:
```suggestion
throw new IgniteInternalCheckedException("Runtime failure on
lookup next row: " + lowerBound, e);
```
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/tree/BplusTree.java:
##########
@@ -1573,17 +1573,18 @@ public final T findOne(L row) throws
IgniteInternalCheckedException {
}
/**
- * Searches for the next row from the passed from the arguments.
+ * Searches for the lowerBound that (strictly or loosely, depending on
{@code includeRow}) follows the lowerBound passed as an
Review Comment:
```suggestion
* Searches for the row that (strictly or loosely, depending on {@code
includeRow}) follows the lowerBound passed as an
```
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/tree/BplusTree.java:
##########
@@ -1592,9 +1593,9 @@ public final T findOne(L row) throws
IgniteInternalCheckedException {
} catch (CorruptedDataStructureException e) {
throw e;
} catch (IgniteInternalCheckedException e) {
- throw new IgniteInternalCheckedException("Runtime failure on
lookup next row: " + row, e);
+ throw new IgniteInternalCheckedException("Runtime failure on
lookup next lowerBound: " + lowerBound, e);
} catch (RuntimeException | AssertionError e) {
- throw corruptedTreeException("Runtime failure on lookup next row:
" + row, e, grpId, g.pageId);
+ throw corruptedTreeException("Runtime failure on lookup next
lowerBound: " + lowerBound, e, grpId, g.pageId);
Review Comment:
```suggestion
throw corruptedTreeException("Runtime failure on lookup next
row: " + lowerBound, e, grpId, g.pageId);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
