ibessonov commented on code in PR #1407:
URL: https://github.com/apache/ignite-3/pull/1407#discussion_r1045512431
##########
modules/storage-api/src/testFixtures/java/org/apache/ignite/internal/storage/index/AbstractSortedIndexStorageTest.java:
##########
@@ -604,148 +605,148 @@ void testScanSimple() {
// Checking without borders.
assertThat(
- scan(indexStorage, null, null, 0).stream().map(objects ->
objects[0]).collect(toList()),
+ scan(indexStorage, null, null, 0,
AbstractSortedIndexStorageTest::firstArrayElement),
contains(0, 1, 2, 3, 4)
);
- // Let's check without borders.
+ // Let's check with borders.
assertThat(
- indexStorage.scan(
- serializer.serializeRowPrefix(0),
- serializer.serializeRowPrefix(4),
- (GREATER_OR_EQUAL | LESS_OR_EQUAL)
- ).stream()
- .map(indexRow ->
serializer.deserializeColumns(indexRow)[0])
- .collect(toList()),
+ scan(
+ indexStorage,
+ serializer.serializeRowPrefix(0),
+ serializer.serializeRowPrefix(4),
+ (GREATER_OR_EQUAL | LESS_OR_EQUAL),
+ AbstractSortedIndexStorageTest::firstArrayElement
+ ),
contains(0, 1, 2, 3, 4)
);
assertThat(
- indexStorage.scan(
- serializer.serializeRowPrefix(0),
- serializer.serializeRowPrefix(4),
- (GREATER_OR_EQUAL | LESS)
- ).stream()
- .map(indexRow ->
serializer.deserializeColumns(indexRow)[0])
- .collect(toList()),
+ scan(
+ indexStorage,
+ serializer.serializeRowPrefix(0),
+ serializer.serializeRowPrefix(4),
+ (GREATER_OR_EQUAL | LESS),
+ AbstractSortedIndexStorageTest::firstArrayElement
+ ),
contains(0, 1, 2, 3)
);
assertThat(
- indexStorage.scan(
- serializer.serializeRowPrefix(0),
- serializer.serializeRowPrefix(4),
- (GREATER | LESS_OR_EQUAL)
- ).stream()
- .map(indexRow ->
serializer.deserializeColumns(indexRow)[0])
- .collect(toList()),
+ scan(
+ indexStorage,
+ serializer.serializeRowPrefix(0),
+ serializer.serializeRowPrefix(4),
+ (GREATER | LESS_OR_EQUAL),
+ AbstractSortedIndexStorageTest::firstArrayElement
+ ),
contains(1, 2, 3, 4)
);
assertThat(
- indexStorage.scan(
- serializer.serializeRowPrefix(0),
- serializer.serializeRowPrefix(4),
- (GREATER | LESS)
- ).stream()
- .map(indexRow ->
serializer.deserializeColumns(indexRow)[0])
- .collect(toList()),
+ scan(
+ indexStorage,
+ serializer.serializeRowPrefix(0),
+ serializer.serializeRowPrefix(4),
+ (GREATER | LESS),
+ AbstractSortedIndexStorageTest::firstArrayElement
+ ),
contains(1, 2, 3)
);
// Let's check only with the lower bound.
assertThat(
- indexStorage.scan(
- serializer.serializeRowPrefix(1),
- null,
- (GREATER_OR_EQUAL | LESS_OR_EQUAL)
- ).stream()
- .map(indexRow ->
serializer.deserializeColumns(indexRow)[0])
- .collect(toList()),
+ scan(
+ indexStorage,
+ serializer.serializeRowPrefix(1),
+ null,
+ (GREATER_OR_EQUAL | LESS_OR_EQUAL),
+ AbstractSortedIndexStorageTest::firstArrayElement
+ ),
contains(1, 2, 3, 4)
);
assertThat(
- indexStorage.scan(
- serializer.serializeRowPrefix(1),
- null,
- (GREATER_OR_EQUAL | LESS)
- ).stream()
- .map(indexRow ->
serializer.deserializeColumns(indexRow)[0])
- .collect(toList()),
+ scan(
+ indexStorage,
+ serializer.serializeRowPrefix(1),
+ null,
+ (GREATER_OR_EQUAL | LESS),
+ AbstractSortedIndexStorageTest::firstArrayElement
+ ),
contains(1, 2, 3, 4)
);
assertThat(
- indexStorage.scan(
- serializer.serializeRowPrefix(1),
- null,
- (GREATER | LESS_OR_EQUAL)
- ).stream()
- .map(indexRow ->
serializer.deserializeColumns(indexRow)[0])
- .collect(toList()),
+ scan(
+ indexStorage,
+ serializer.serializeRowPrefix(1),
+ null,
+ (GREATER | LESS_OR_EQUAL),
+ AbstractSortedIndexStorageTest::firstArrayElement
+ ),
contains(2, 3, 4)
);
assertThat(
- indexStorage.scan(
- serializer.serializeRowPrefix(1),
- null,
- (GREATER | LESS)
- ).stream()
- .map(indexRow ->
serializer.deserializeColumns(indexRow)[0])
- .collect(toList()),
+ scan(
+ indexStorage,
+ serializer.serializeRowPrefix(1),
+ null,
+ (GREATER | LESS),
Review Comment:
Just a question, why did you add parentheses here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
