ibessonov commented on code in PR #1505:
URL: https://github.com/apache/ignite-3/pull/1505#discussion_r1065496723
##########
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/StorageException.java:
##########
@@ -17,17 +17,23 @@
package org.apache.ignite.internal.storage;
+import org.apache.ignite.lang.ErrorGroups.Storage;
+import org.apache.ignite.lang.IgniteInternalException;
+
/**
* Exception thrown by the storage.
*/
-public class StorageException extends RuntimeException {
+public class StorageException extends IgniteInternalException {
+ /** Serial version uid. */
+ private static final long serialVersionUID = 8705275268121031742L;
Review Comment:
To avoid annoying warnings, internal exception is serializable
##########
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/StorageClosedException.java:
##########
@@ -17,35 +17,19 @@
package org.apache.ignite.internal.storage;
+import org.apache.ignite.lang.ErrorGroups.Storage;
+
/**
* Exception that will be thrown when the storage is closed.
*/
public class StorageClosedException extends StorageException {
- /**
- * Constructor.
- *
- * @param message Error message.
- */
- public StorageClosedException(String message) {
- super(message);
- }
-
- /**
- * Constructor.
- *
- * @param message Error message.
- * @param cause The cause.
- */
- public StorageClosedException(String message, Throwable cause) {
- super(message, cause);
- }
+ /** Serial version uid. */
+ private static final long serialVersionUID = -7988332521347221109L;
Review Comment:
Same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
