[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #1528: IGNITE-18422: Sql. Match number of dynamic parameters with given parameters

[GitBox]

AMashenkov commented on code in PR #1528:
URL: https://github.com/apache/ignite-3/pull/1528#discussion_r1082316721


##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/util/QueryChecker.java:
##########
@@ -363,27 +365,54 @@ public QueryChecker planEquals(String plan) {
         return this;
     }
 
+    /**
+     * Specifies whether to execute {@code EXPLAIN PLAN FOR} statement before 
running a query or not.
+     * The default value is {@code true}.
+     * <p>
+     * If the value is set to {@code false} but either plan or at least one 
plan matcher is specified {@link #check()}
+     * throws {@link IllegalStateException}.
+     * </p>
+     *
+     * @param value whether to execute EXPLAIN PLAN statement or not.
+     * @return this

Review Comment:
   ```suggestion
        *
        * @param value whether to execute EXPLAIN PLAN statement or not.
        * @return {@code this}
        * @throws IllegalStateException If the value is set to {@code false} 
but either plan or at least one plan matcher is specified {@link #check()}
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org