[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #1528: IGNITE-18422: Sql. Match number of dynamic parameters with given parameters

[GitBox]

AMashenkov commented on code in PR #1528:
URL: https://github.com/apache/ignite-3/pull/1528#discussion_r1082320651


##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/util/QueryChecker.java:
##########
@@ -251,6 +251,8 @@ public static Matcher<String> containsAnyScan(final String 
schema, final String
 
     private String exactPlan;
 
+    private boolean executeExplainPlan = true;

Review Comment:
   It looks unclear for me. 
   If `executeExplainPlan` is true, then will the query itself be excecuted, or 
just EXPLAIN for the query?
   Maybe `skipExplan` will be more precise name.



##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/util/QueryChecker.java:
##########
@@ -251,6 +251,8 @@ public static Matcher<String> containsAnyScan(final String 
schema, final String
 
     private String exactPlan;
 
+    private boolean executeExplainPlan = true;

Review Comment:
   It looks unclear for me. 
   If `executeExplainPlan` is true, then will the query itself be excecuted, or 
just EXPLAIN for the query?
   Maybe `skipExplain` will be more precise name.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org