korlov42 commented on code in PR #1524:
URL: https://github.com/apache/ignite-3/pull/1524#discussion_r1082404654
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/SortAggregateNode.java:
##########
@@ -76,7 +75,6 @@ public SortAggregateNode(
Comparator<RowT> comp
) {
super(ctx);
- assert Objects.nonNull(comp);
Review Comment:
I would prefer to leave this assertion as is.
Without this assertion, a situation in which we would have previously
obtained either an assertion error or an NPE would now lead to the wrong result.
Perhaps, we could cover single group case by providing comparator returning
0 every time, WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
