korlov42 commented on code in PR #1524:
URL: https://github.com/apache/ignite-3/pull/1524#discussion_r1082427170
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/SortAggregateNode.java:
##########
@@ -159,6 +161,10 @@ public void end() throws Exception {
waiting = -1;
+ if (grp == null && accFactory != null) {
Review Comment:
this will produce empty row when none is expected in query like `SELECT
min(c) FROM t GROUP BY a` when table is empty. BTW, we need execution test for
this case
to initialise group properly, please, take a look at
`org.apache.ignite.internal.sql.engine.exec.rel.HashAggregateNode.Grouping#init`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
