[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #1503: IGNITE-18324 Calling tx.rollback() or tx.commit() is not failed for committed transaction.

[GitBox]

sergeyuttsel commented on code in PR #1503:
URL: https://github.com/apache/ignite-3/pull/1503#discussion_r1082413152


##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/ReadWriteTransactionImpl.java:
##########
@@ -88,8 +93,12 @@ public IgniteBiTuple<ClusterNode, Long> 
enlist(ReplicationGroupId replicationGro
     /** {@inheritDoc} */
     @Override
     protected CompletableFuture<Void> finish(boolean commit) {
+        if (!finishFut.compareAndSet(null, new CompletableFuture<>())) {
+            return finishFut.get();
+        }
+
         // TODO: https://issues.apache.org/jira/browse/IGNITE-17688 Add proper 
exception handling.
-        return CompletableFuture
+        CompletableFuture<Void> mainFinishFut = CompletableFuture

Review Comment:
   For me it is good. And I don't want to wrack my brain :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org