sergeyuttsel commented on code in PR #1503:
URL: https://github.com/apache/ignite-3/pull/1503#discussion_r1082417133
##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/ReadWriteTransactionImpl.java:
##########
@@ -126,10 +135,14 @@ protected CompletableFuture<Void> finish(boolean commit) {
id()
);
} else {
- return CompletableFuture.completedFuture(null);
+ return completedFuture(null);
}
}
);
+
+ mainFinishFut.handle((res, e) -> finishFut.get().complete(null));
Review Comment:
It is need to complete future both on success and exception.
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java:
##########
@@ -279,12 +280,13 @@ private void handleUpdateAllCommand(UpdateAllCommand cmd,
long commandIndex, lon
* @param cmd Command.
* @param commandIndex Index of the RAFT command.
* @param commandTerm Term of the RAFT command.
+ * @return {@code true} if transaction state was changed.
* @throws IgniteInternalException if an exception occurred during a
transaction state change.
*/
- private void handleFinishTxCommand(FinishTxCommand cmd, long commandIndex,
long commandTerm) throws IgniteInternalException {
+ private boolean handleFinishTxCommand(FinishTxCommand cmd, long
commandIndex, long commandTerm) throws IgniteInternalException {
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
