timoninmaxim commented on code in PR #10512: URL: https://github.com/apache/ignite/pull/10512#discussion_r1095794847
########## modules/core/src/main/java/org/apache/ignite/spi/systemview/view/ConfigurationView.java: ########## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.spi.systemview.view; + +import org.apache.ignite.internal.managers.systemview.walker.Order; + +/** + * Configuration value representation for a {@link SystemView}. + */ +public class ConfigurationView { + /** Name of the configuration property. */ + private final String name; + + /** Value of the configuration property. */ + private final String val; + + /** + * @param name Name of the configuration property. + * @param val Value of the configuration property. + */ + public ConfigurationView(String name, String val) { + this.name = name; + this.val = val; + } + + /** @return Name of the configuration property. */ + @Order + public String name() { + return name; + } + + /** @return Value of the configuration property. */ + public String value() { Review Comment: Should we add explicit Order here? ########## modules/core/src/main/java/org/apache/ignite/internal/managers/systemview/GridSystemViewManager.java: ########## @@ -65,6 +74,15 @@ public GridSystemViewManager(GridKernalContext ctx) { /** {@inheritDoc} */ @Override public void start() throws IgniteCheckedException { + registerInnerCollectionView( Review Comment: Lets move view registration from this place. It looks like good place is in IgniteKernal#start after `registerMetrics`, it's also a similar system call. ########## modules/core/src/main/java/org/apache/ignite/IgniteSystemProperties.java: ########## @@ -2099,6 +2099,16 @@ public final class IgniteSystemProperties { @IgniteExperimental public static final String IGNITE_SNAPSHOT_SEQUENTIAL_WRITE = "IGNITE_SNAPSHOT_SEQUENTIAL_WRITE"; + /** + * Comma separated packages list to expose in configuration view. + * The default value is null. + * @see org.apache.ignite.internal.managers.systemview.GridSystemViewManager#CFG_VIEW + * @see org.apache.ignite.spi.systemview.view.ConfigurationView + */ + @SystemProperty(value = "Packages list to expose in configuration view") + @IgniteExperimental + public static final String IGNITE_CONFIGURATION_VIEW_PACKAGES = "IGNITE_CONFIGURATION_VIEW_PACKAGES"; Review Comment: What is a goal for external packages? Is it possible user extends IgniteConfiguration, puts some new properties, then tries to use it in a custom plugin? let's add a test for that. Also it's worth to say in docs that properties within "org.apache.ignite" package shows event if this property is set. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
