xtern commented on code in PR #1823: URL: https://github.com/apache/ignite-3/pull/1823#discussion_r1150854635
########## modules/runner/src/integrationTest/sql/types/decimal/test_decimal_ops.test: ########## @@ -5,9 +5,8 @@ statement ok PRAGMA enable_verification -skipif ignite3 -# https://issues.apache.org/jira/browse/IGNITE-18655 -statement error + +statement ok CREATE TABLE decimals_without_params(d DECIMAL); Review Comment: may be we should somehow check precision/scale parameters, that we can something insert/select or at least add comment explaining this test case? e.g. ``` statement ok CREATE TABLE decimals_without_params(d DECIMAL); INSERT INTO decimals_without_params values(1234567890.12345); query T SELECT * FROM decimals_without_params ---- ...expected ``` Should we add a similar test with precision only defined? ``` CREATE TABLE decimals_without_params2(d DECIMAL(9)); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
