xtern commented on code in PR #1880:
URL: https://github.com/apache/ignite-3/pull/1880#discussion_r1164040869
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/JdbcQueryEventHandlerImpl.java:
##########
@@ -287,6 +300,26 @@ public CompletableFuture<JdbcMetaPrimaryKeysResult>
primaryKeysMetaAsync(JdbcMet
return meta.getPrimaryKeys(req.schemaName(),
req.tableName()).thenApply(JdbcMetaPrimaryKeysResult::new);
}
+ /** {@inheritDoc} */
+ @Override
+ public CompletableFuture<JdbcFinishTxResult> finishTxAsync(long
connectionId, boolean commit) {
+ JdbcConnectionContext connectionContext;
+
+ try {
+ connectionContext =
resources.get(connectionId).get(JdbcConnectionContext.class);
Review Comment:
Probably yes, but I don’t quite understand from the code where we removing
it now.
Currently, if the resource (ConnectionContext) is released the active
transaction is rolled back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
