xtern commented on code in PR #1880:
URL: https://github.com/apache/ignite-3/pull/1880#discussion_r1164315867
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/JdbcQueryEventHandlerImpl.java:
##########
@@ -442,6 +481,22 @@ private SessionId recreateSession(@Nullable SessionId
expectedSessionId) {
}
}
+ private Transaction getOrStartTransaction() {
+ return tx == null ? tx = igniteTransactions.begin() : tx;
Review Comment:
My understanding is that each JDBC connection under the hood holds a client,
each client holds a channel, and each channel is served by a separate worker
thread. One worker thread can serve multiple channels, but each channel is
serviced by the same worker thread. Therefore it seemed to me that this method
cannot be called by different threads.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
