sanpwc commented on code in PR #2172:
URL: https://github.com/apache/ignite-3/pull/2172#discussion_r1234836916
##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java:
##########
@@ -946,81 +955,11 @@ private void
updateLogicalTopologyInMetaStorage(LogicalTopologySnapshot newTopol
}
}
- /**
- * Initialises {@link DistributionZonesUtil#zonesLogicalTopologyKey()} and
- * {@link DistributionZonesUtil#zonesLogicalTopologyVersionKey()} from
meta storage on the start of {@link DistributionZoneManager}.
- */
- private void initLogicalTopologyAndVersionInMetaStorageOnStart() {
Review Comment:
So, in order to remove given method and still preserve all guarantees you've
added
```
if (newTopology.version() == 1) {
// Very first start of the cluster, so we just initialize
zonesLogicalTopologyVersionKey
updateCondition =
notExists(zonesLogicalTopologyVersionKey());
}
```
Is that correct?
Did you add anything else besides aforementioned code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
