alievmirza commented on code in PR #2172:
URL: https://github.com/apache/ignite-3/pull/2172#discussion_r1229643997
##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java:
##########
@@ -1119,9 +1130,8 @@ public CompletableFuture<Void> onUpdate(WatchEvent evt) {
.map(NodeWithAttributes::node)
.collect(toSet());
- newLogicalTopology.forEach(n ->
nodesAttributes.put(n.nodeId(), n.nodeAttributes()));
+
updateLogicalTopologyNodeAttributesAndSaveToVault(newLogicalTopology);
Review Comment:
Thanks for noticing! IMHO right behaviour here is to call
`updateLogicalTopologyNodeAttributesAndSaveToVault` right after the
WatchListener was successfully handled. In that case, your case won't occur, so
data in vault will be consistent with `WatchListener`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
