sashapolo commented on code in PR #2370:
URL: https://github.com/apache/ignite-3/pull/2370#discussion_r1276611387
##########
modules/transactions/src/test/java/org/apache/ignite/internal/tx/storage/state/rocksdb/RocksDbTxStateStorageTest.java:
##########
@@ -43,18 +48,28 @@ public class RocksDbTxStateStorageTest extends
AbstractTxStateStorageTest {
@WorkDirectory
private Path workDir;
+ private final ScheduledExecutorService scheduledExecutor = new
ScheduledThreadPoolExecutor(1);
Review Comment:
Not really an issue, but I would suggest to use
`Executors.newSingleThreadScheduledExecutor`
##########
modules/transactions/src/test/java/org/apache/ignite/internal/tx/storage/state/rocksdb/RocksDbTxStateStorageTest.java:
##########
@@ -43,18 +48,28 @@ public class RocksDbTxStateStorageTest extends
AbstractTxStateStorageTest {
@WorkDirectory
private Path workDir;
+ private final ScheduledExecutorService scheduledExecutor = new
ScheduledThreadPoolExecutor(1);
+
+ private final ExecutorService executor = Executors.newFixedThreadPool(1);
Review Comment:
Same here, we can change it to `Executors.newSingleThreadExecutor` for
consistency sake
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
