sashapolo commented on code in PR #2370:
URL: https://github.com/apache/ignite-3/pull/2370#discussion_r1276615771
##########
modules/transactions/src/test/java/org/apache/ignite/internal/tx/storage/state/rocksdb/RocksDbTxStateStorageTest.java:
##########
@@ -43,18 +48,28 @@ public class RocksDbTxStateStorageTest extends
AbstractTxStateStorageTest {
@WorkDirectory
private Path workDir;
+ private final ScheduledExecutorService scheduledExecutor = new
ScheduledThreadPoolExecutor(1);
+
+ private final ExecutorService executor = Executors.newFixedThreadPool(1);
+
@Override
protected TxStateRocksDbTableStorage createTableStorage() {
return new TxStateRocksDbTableStorage(
1,
3,
workDir,
- new ScheduledThreadPoolExecutor(1),
- Executors.newFixedThreadPool(1),
+ scheduledExecutor,
+ executor,
() -> 1_000
);
}
+ @AfterEach
+ void shutdownExecutors() {
Review Comment:
I'm a little bit worried that we stop the executors before we close the
storage, maybe we should override the parent's `AfterEach` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
