korlov42 commented on code in PR #2397:
URL: https://github.com/apache/ignite-3/pull/2397#discussion_r1287254692
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/framework/TestBuilders.java:
##########
@@ -780,6 +790,9 @@ private interface TableBuilderBase<ChildT> {
/** Sets the distribution of the table. */
ChildT distribution(IgniteDistribution distribution);
+ /** Adds a key column to the table. */
+ ChildT addKeyColumn(String name, NativeType type);
Review Comment:
please, ignore comment above, because it doesn't make any sense... Different
distributions can be specified explicitly with distribution setter, and on the
level of TableDescriptor an order of key columns doesn't make any difference,
thus I'm ok to go with proposed change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
