xtern commented on code in PR #2397:
URL: https://github.com/apache/ignite-3/pull/2397#discussion_r1288568303
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/UpdatableTableImpl.java:
##########
@@ -281,29 +281,17 @@ public <RowT> CompletableFuture<?> deleteAll(
private <RowT> BinaryRowEx convertRow(RowT row, ExecutionContext<RowT>
ectx, boolean keyOnly) {
RowHandler<RowT> hnd = ectx.rowHandler();
- for (ColumnDescriptor colDesc : columnsOrderedByPhysSchema) {
- if (keyOnly && !colDesc.key()) {
- continue;
- }
-
- Object value = hnd.get(colDesc.logicalIndex(), row);
-
- // TODO Remove this check when
https://issues.apache.org/jira/browse/IGNITE-19096 is complete
- assert value != DEFAULT_VALUE_PLACEHOLDER;
-
- if (value == null) {
- break;
- }
- }
-
RowAssembler rowAssembler = keyOnly ?
RowAssembler.keyAssembler(schemaDescriptor) : new
RowAssembler(schemaDescriptor);
for (ColumnDescriptor colDesc : columnsOrderedByPhysSchema) {
if (keyOnly && !colDesc.key()) {
continue;
}
- Object val = hnd.get(colDesc.logicalIndex(), row);
+ Object val = hnd.get(keyOnly ? colDesc.physicalIndex() :
colDesc.logicalIndex(), row);
Review Comment:
Thanks, fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
