Cyrill commented on code in PR #2679:
URL: https://github.com/apache/ignite-3/pull/2679#discussion_r1362015747
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -2606,6 +2629,7 @@ private CompletableFuture<ReplicaResult>
processSingleEntryAction(ReadWriteSingl
return takeLocksForDelete(row, rowId, txId)
.thenCompose(ignored ->
validateOperationAgainstSchema(request.transactionId()))
+ .thenCompose(catalogVersion -> checkCleanup(rowId,
catalogVersion))
Review Comment:
Is there any benefit from doing this? All `checkCleanup` does it checks the
status of the cleanup and returns immediately or waits for the cleanup to end.
It does not initiate any request.
So the time when `allof(schema, cleanup)` ends is fairly similar to
`schema.then(cleanup)`. But the current approach is much cleaner than ignored
vars and joins
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
