sanpwc commented on code in PR #2679:
URL: https://github.com/apache/ignite-3/pull/2679#discussion_r1362470573
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -1763,12 +1768,15 @@ private CompletableFuture<ReplicaResult>
processMultiEntryAction(ReadWriteMultiR
return allOf(deleteExactLockFuts).thenCompose(ignore -> {
Map<UUID, BinaryRowMessage> rowIdsToDelete = new
HashMap<>();
Collection<BinaryRow> result = new ArrayList<>();
+ List<RowId> rows = new ArrayList<>();
for (int i = 0; i < searchRows.size(); i++) {
RowId lockedRowId = deleteExactLockFuts[i].join();
if (lockedRowId != null) {
rowIdsToDelete.put(lockedRowId.uuid(), null);
+
+ rows.add(lockedRowId);
Review Comment:
But prior to insertion we should check whether there is row with given pk
and it's possible that given row will be a writeIntent. Do we schedule such
writeIntent cleanup? I mean that it's not necessary to await such cleanup on
insert, but still worth to schedule it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
