vldpyatkov commented on code in PR #2757:
URL: https://github.com/apache/ignite-3/pull/2757#discussion_r1373166580
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java:
##########
@@ -787,6 +790,13 @@ public CompletableFuture<Void> closeAsync() {
}
private void enlistPartitions(MappedFragment mappedFragment,
InternalTransaction tx) {
+ // It's possible to have null txState if transaction isn't started
yet.
Review Comment:
I create another issue where we will be able to think about the _null_
state. Just now, I do not have a strong position; probably null is not needed
anymore; the PENDING state is enough or not; and I am missing something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
