ygerzhedovich commented on code in PR #2757:
URL: https://github.com/apache/ignite-3/pull/2757#discussion_r1373085883


##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java:
##########
@@ -787,6 +790,13 @@ public CompletableFuture<Void> closeAsync() {
         }
 
         private void enlistPartitions(MappedFragment mappedFragment, 
InternalTransaction tx) {
+            // It's possible to have null txState if transaction isn't started 
yet.

Review Comment:
   But personally I would prefer additional state instead of null value



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to