alievmirza commented on code in PR #3150:
URL: https://github.com/apache/ignite-3/pull/3150#discussion_r1485899063
##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/Loza.java:
##########
@@ -175,6 +170,11 @@ public void
actionRequestInterceptor(ActionRequestInterceptor actionRequestInter
/** {@inheritDoc} */
@Override
public CompletableFuture<Void> start() {
+ executor = new ScheduledThreadPoolExecutor(
Review Comment:
All over the codebase we create executors in constructors, why have you
moved this executor to the start method?
##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/Loza.java:
##########
@@ -175,6 +170,11 @@ public void
actionRequestInterceptor(ActionRequestInterceptor actionRequestInter
/** {@inheritDoc} */
@Override
public CompletableFuture<Void> start() {
+ executor = new ScheduledThreadPoolExecutor(
Review Comment:
All over the codebase we create executors in constructors, why have you
moved this executor init to the start method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
