alievmirza commented on code in PR #3150:
URL: https://github.com/apache/ignite-3/pull/3150#discussion_r1525075289


##########
modules/replicator/src/testFixtures/java/org/apache/ignite/internal/raft/client/AbstractTopologyAwareGroupServiceTest.java:
##########
@@ -261,26 +259,24 @@ private IgniteBiTuple<TopologyAwareRaftGroupService, 
TopologyAwareRaftGroupServi
 
         afterClusterInit(leader.name());
 
+        raftClients.add(raftClient);

Review Comment:
   I would move this to the 
`org.apache.ignite.internal.raft.client.AbstractTopologyAwareGroupServiceTest#startCluster`
   
   because in the test 
`org.apache.ignite.internal.raft.client.AbstractTopologyAwareGroupServiceTest#testOneNodeReplicationGroup`
 we do not add created client to `raftClients`, hence we do not shutdown it 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to