ibessonov commented on code in PR #3379:
URL: https://github.com/apache/ignite-3/pull/3379#discussion_r1540909782
##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/rebalance/RebalanceRaftGroupEventsListener.java:
##########
@@ -491,24 +491,21 @@ static void doStableKeySwitch(
Condition con5;
if (plannedEntry.value() != null) {
// eq(revision(partition.assignments.planned),
plannedEntry.revision)
- con5 = and(
-
revision(plannedPartAssignmentsKey).eq(plannedEntry.revision()),
-
value(pendingPartAssignmentsKey).eq(stableFromRaftByteArray)
- );
+ con5 =
revision(plannedPartAssignmentsKey).eq(plannedEntry.revision());
Review Comment:
To the reviewer: these changes fix bugs in the method, where a comparison
wouldn't work if pending assignment is forced, but stable assignment is not.
In fact, this condition was not only wrong, but excessive, because we
control for it in `con2`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
