sanpwc commented on code in PR #3467:
URL: https://github.com/apache/ignite-3/pull/3467#discussion_r1544172067
##########
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/Replica.java:
##########
@@ -168,7 +175,25 @@ private CompletableFuture<ClusterNode> leaderFuture() {
*/
public CompletableFuture<? extends NetworkMessage>
processPlacementDriverMessage(PlacementDriverReplicaMessage msg) {
if (msg instanceof LeaseGrantedMessage) {
- return processLeaseGrantedMessage((LeaseGrantedMessage) msg);
+ return processLeaseGrantedMessage((LeaseGrantedMessage) msg)
+ .handle((v, e) -> {
Review Comment:
That doesn't feel correct. I agree that we should start the negotiation from
the beginning in case of exceptions. However, from my point of view, that means
that we should have generic exceptional leaseGrantResponse in case of any
exception. What's the point of dedicated handling of NodeStopping one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
