sanpwc commented on code in PR #3467: URL: https://github.com/apache/ignite-3/pull/3467#discussion_r1544186717
########## modules/replicator/src/main/java/org/apache/ignite/internal/replicator/exception/FullTransactionPrimaryReplicaMissException.java: ########## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.replicator.exception; + +import static org.apache.ignite.lang.ErrorGroups.Replicator.REPLICA_MISS_ERR; + +import org.apache.ignite.internal.lang.IgniteInternalException; + +/** + * This exception is used when a full transaction misses primary replica. + */ +public class FullTransactionPrimaryReplicaMissException extends IgniteInternalException implements TransactionRetryAllowingException { Review Comment: Basically it's not about an exception but about a place from where you throw it. Currently it's PartitionReplicaListener.java, and from the replication point of view it actually should not know that it's a full transaction, basically it's just an operation that hits expired primary replcia, meaning that proper expcetion to throws is a PrimaryReplicaExpiredException or similar. And within the tx-aware layer we should retry the operation if it's full transaction. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
