sanpwc commented on code in PR #3629:
URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1576119948
##########
modules/network/src/testFixtures/java/org/apache/ignite/internal/network/utils/ClusterServiceTestUtils.java:
##########
@@ -178,24 +179,26 @@ public CompletableFuture<Void> start() {
)
).join();
- bootstrapFactory.start();
+ bootstrapFactory.startAsync();
- clusterSvc.start();
+ clusterSvc.startAsync();
return nullCompletedFuture();
}
@Override
- public void stop() {
+ public CompletableFuture<Void> stopAsync() {
try {
IgniteUtils.closeAll(
Review Comment:
How are we going to handle async exceptions inside closeAll? I mean that it
was designed to close as much as possible, semi-ignoring pending exceptions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
