sanpwc commented on code in PR #3629:
URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579528313
##########
modules/catalog/src/testFixtures/java/org/apache/ignite/internal/catalog/CatalogTestUtils.java:
##########
@@ -126,10 +124,8 @@ public void beforeNodeStop() {
}
@Override
- public void stop() throws Exception {
- super.stop();
-
- metastore.stop();
+ public CompletableFuture<Void> stopAsync() {
+ return allOf(super.stopAsync(), metastore.stopAsync());
Review Comment:
Same as above. Basically there are plenty of places within tests where it's
better to use best-effort stop logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
