Vladsz83 commented on code in PR #11327:
URL: https://github.com/apache/ignite/pull/11327#discussion_r1587926027
##########
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java:
##########
@@ -6781,12 +6780,12 @@ else if (req.changeTopology()) {
"previous [" + previous + "] with
timeout " + backwardCheckTimeout);
}
- liveAddr = checkConnection(new
ArrayList<>(nodeAddrs), backwardCheckTimeout);
+ liveAddr = checkConnection(previous,
backwardCheckTimeout);
if (log.isInfoEnabled()) {
log.info("Connection check to previous
node done: [liveAddr=" + liveAddr
- + ", previousNode=" +
U.toShortString(previous) + ", addressesToCheck=" +
- nodeAddrs + ", connectingNodeId=" +
nodeId + ']');
+ + ", previousNode=" +
U.toShortString(previous) + ", connectingNodeId="
Review Comment:
Suggestion: I see warnings in the code if some node doesn't respond. Let's
make `U.warn()` if node check failed. And we might emphasize "Connection check
to previous failed" ("done -> failed")
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
