maksaska commented on code in PR #11327:
URL: https://github.com/apache/ignite/pull/11327#discussion_r1580681985
##########
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java:
##########
@@ -7287,10 +7287,18 @@ private InetSocketAddress
checkConnection(List<InetSocketAddress> addrs, int tim
sock.connect(addr, perAddrTimeout);
liveAddrHolder.compareAndSet(null, addr);
+
Review Comment:
You're right! There is no need for such excessive logging. I removed it
##########
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java:
##########
@@ -7287,10 +7287,18 @@ private InetSocketAddress
checkConnection(List<InetSocketAddress> addrs, int tim
sock.connect(addr, perAddrTimeout);
liveAddrHolder.compareAndSet(null, addr);
+
+ if (log.isInfoEnabled())
+ log.info("Successful connection to the
server [address=" + addr + "]");
+ }
+ else if (log.isInfoEnabled()) {
Review Comment:
I believe we need INFO level here for analysis purpuse. The aftermath for
some incident is easier to resolve, if the log is already there, that is at the
time the incident is taking place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
