JAkutenshi commented on code in PR #3633:
URL: https://github.com/apache/ignite-3/pull/3633#discussion_r1594554150
##########
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/Replica.java:
##########
@@ -119,7 +117,7 @@ public Replica(
this.replicaGrpId = replicaGrpId;
this.listener = listener;
this.storageIndexTracker = storageIndexTracker;
- this.raftClient = raftClient;
+ this.raftClient = raftClient();
Review Comment:
✅ Just because of class casting: inside the method I cast client to the
specific `Replica`'s raft client type. And a better way to localize such too
specific (workaround? see TODO there) things in one certain method.
##########
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java:
##########
@@ -465,29 +461,101 @@ private void stopLeaseProlongation(ReplicationGroupId
groupId, @Nullable String
});
}
+ public CompletableFuture<Replica> getReplica(ReplicationGroupId
replicationGroupId) {
Review Comment:
✅ Just yet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
