Re: [PR] IGNITE-21805 Refactor TableManager and move all RAFT related pieces to Replica [ignite-3]

[via GitHub]

JAkutenshi commented on code in PR #3633:
URL: https://github.com/apache/ignite-3/pull/3633#discussion_r1594489741


##########
modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java:
##########
@@ -611,6 +613,7 @@ public class IgniteImpl implements Ignite {
 
         LongSupplier partitionIdleSafeTimePropagationPeriodMsSupplier = 
partitionIdleSafeTimePropagationPeriodMsSupplier(replicationConfig);
 
+        Marshaller raftMarshaller = new 
ThreadLocalPartitionCommandsMarshaller(clusterSvc.serializationRegistry());

Review Comment:
   I would, but there is circular dependency issue happens on 
`ThreadLocalPartitionCommandsMarshaller`. Is there any way to overcome this for 
the particular case?
   
![image](https://github.com/apache/ignite-3/assets/7635910/b003c9ac-42c9-4890-a92c-075090b925de)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org