ptupitsyn commented on code in PR #3920:
URL: https://github.com/apache/ignite-3/pull/3920#discussion_r1639517128
##########
modules/compute/src/test/java/org/apache/ignite/internal/compute/loader/JobClassLoaderFactoryTest.java:
##########
@@ -64,14 +65,14 @@ public void unit1() throws Exception {
// then classes from the first unit are loaded from the first
class loader
Class<?> clazz1 = classLoader1.loadClass(UNIT_JOB_CLASS_NAME);
ComputeJob<Integer> job1 = (ComputeJob<Integer>)
clazz1.getDeclaredConstructor().newInstance();
- Integer result1 = job1.execute(null);
- assertEquals(1, result1);
+ CompletableFuture<Integer> result1 = job1.executeAsync(null);
+ assertEquals(1, result1.join());
Review Comment:
Is it better and why? I'm trying to keep the changes to a minimum here, with
`join()` you can see easier that the test is the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
