ptupitsyn commented on code in PR #3920:
URL: https://github.com/apache/ignite-3/pull/3920#discussion_r1639561953
##########
modules/compute/src/test/java/org/apache/ignite/internal/compute/loader/JobClassLoaderFactoryTest.java:
##########
@@ -90,8 +91,8 @@ public void unit1BothVersions() throws Exception {
// and classes are loaded in the aplhabetical order
ComputeJob<Integer> job1 = (ComputeJob<Integer>)
unitJobClass.getDeclaredConstructor().newInstance();
- Integer result1 = job1.execute(null);
- assertEquals(1, result1);
+ CompletableFuture<Integer> result1 = job1.executeAsync(null);
+ assertEquals(1, result1.join());
Review Comment:
Fixed.
##########
modules/compute/src/test/java/org/apache/ignite/internal/compute/loader/JobClassLoaderFactoryTest.java:
##########
@@ -64,14 +65,14 @@ public void unit1() throws Exception {
// then classes from the first unit are loaded from the first
class loader
Class<?> clazz1 = classLoader1.loadClass(UNIT_JOB_CLASS_NAME);
ComputeJob<Integer> job1 = (ComputeJob<Integer>)
clazz1.getDeclaredConstructor().newInstance();
- Integer result1 = job1.execute(null);
- assertEquals(1, result1);
+ CompletableFuture<Integer> result1 = job1.executeAsync(null);
+ assertEquals(1, result1.join());
// and classes from the second unit are loaded from the second
class loader
Class<?> clazz2 = classLoader2.loadClass(UNIT_JOB_CLASS_NAME);
ComputeJob<String> job2 = (ComputeJob<String>)
clazz2.getDeclaredConstructor().newInstance();
- String result2 = job2.execute(null);
- assertEquals("Hello World!", result2);
+ CompletableFuture<String> result2 = job2.executeAsync(null);
+ assertEquals("Hello World!", result2.join());
Review Comment:
Fixed.
##########
modules/compute/src/test/java/org/apache/ignite/internal/compute/loader/JobClassLoaderFactoryTest.java:
##########
@@ -64,14 +65,14 @@ public void unit1() throws Exception {
// then classes from the first unit are loaded from the first
class loader
Class<?> clazz1 = classLoader1.loadClass(UNIT_JOB_CLASS_NAME);
ComputeJob<Integer> job1 = (ComputeJob<Integer>)
clazz1.getDeclaredConstructor().newInstance();
- Integer result1 = job1.execute(null);
- assertEquals(1, result1);
+ CompletableFuture<Integer> result1 = job1.executeAsync(null);
+ assertEquals(1, result1.join());
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
